build-compare disfunct

Discussion:

Stephan Kulow

2014-07-22 05:32:49 UTC

Hi,

Several people touched build-compare lately and I'm afraid it's right
now completely broken.

I reviewed several build logs and they are all changed with this log:

[ 119s] ... comparing built packages with the former built
[ 119s] /usr/lib/build/rpm-check.sh
[ 119s] compare /.build.oldpackages/xteddy-2.2-22.1.src.rpm /home/abuild/rpmbuild/SRPMS/xteddy-2.2-22.2.src.rpm
[ 119s] compare /.build.oldpackages/xteddy-2.2-22.1.i586.rpm /home/abuild/rpmbuild/RPMS/i586/xteddy-2.2-22.2.i586.rpm
[ 120s] WARNING: no idea about /usr/bin/xteddy
[ 120s] compare /.build.oldpackages/xteddy-debuginfo-2.2-22.1.i586.rpm /home/abuild/rpmbuild/RPMS/i586/xteddy-debuginfo-2.2-22.2.i586.rpm
[ 120s] skipping -debuginfo package
[ 120s] compare /.build.oldpackages/xteddy-debugsource-2.2-22.1.i586.rpm /home/abuild/rpmbuild/RPMS/i586/xteddy-debugsource-2.2-22.2.i586.rpm
[ 121s] comparing /.build.oldpackages/rpmlint.log and /home/abuild/rpmbuild/OTHER/rpmlint.log

After the "no idea about" is a return 1, so this is considered different without an idea.

Greetings, Stephan

--
Ma muaß weiterkämpfen, kämpfen bis zum Umfalln, a wenn die
ganze Welt an Arsch offen hat, oder grad deswegn.
--
To unsubscribe, e-mail: opensuse-packaging+***@opensuse.org
To contact the owner, e-mail: opensuse-packaging+***@opensuse.org

Andreas Schwab

2014-07-22 06:40:49 UTC

Permalink

Post by Stephan Kulow
After the "no idea about" is a return 1, so this is considered different without an idea.

/usr/bin/xteddy only differs in build-id, so no change in behaviour
apart from the message ("differs in ELF sections" vs "no idea about").

Andreas.

--
Andreas Schwab, SUSE Labs, ***@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
--
To unsubscribe, e-mail: opensuse-packaging+***@opensuse.org
To contact the owner, e-mail: opensuse-packaging+***@opensuse.org

Stephan Kulow

2014-07-22 07:26:23 UTC

Permalink

Post by Andreas Schwab

Post by Stephan Kulow
After the "no idea about" is a return 1, so this is considered different without an idea.

/usr/bin/xteddy only differs in build-id, so no change in behaviour
apart from the message ("differs in ELF sections" vs "no idea about").

But that's exactly what https://build.opensuse.org/request/show/239818
tried to fix.

Greetings, Stephan

--
To unsubscribe, e-mail: opensuse-packaging+***@opensuse.org
To contact the owner, e-mail: opensuse-packaging+***@opensuse.org

Andreas Schwab

2014-07-22 07:33:15 UTC

Permalink

Post by Stephan Kulow

Post by Andreas Schwab

Post by Stephan Kulow
After the "no idea about" is a return 1, so this is considered different without an idea.

/usr/bin/xteddy only differs in build-id, so no change in behaviour
apart from the message ("differs in ELF sections" vs "no idea about").

But that's exactly what https://build.opensuse.org/request/show/239818
tried to fix.

And failed.

Andreas.

Marcus Meissner

2014-07-22 06:44:09 UTC

Permalink

Post by Stephan Kulow
Hi,
Several people touched build-compare lately and I'm afraid it's right
now completely broken.
[ 119s] ... comparing built packages with the former built
[ 119s] /usr/lib/build/rpm-check.sh
[ 119s] compare /.build.oldpackages/xteddy-2.2-22.1.src.rpm /home/abuild/rpmbuild/SRPMS/xteddy-2.2-22.2.src.rpm
[ 119s] compare /.build.oldpackages/xteddy-2.2-22.1.i586.rpm /home/abuild/rpmbuild/RPMS/i586/xteddy-2.2-22.2.i586.rpm
[ 120s] WARNING: no idea about /usr/bin/xteddy
[ 120s] compare /.build.oldpackages/xteddy-debuginfo-2.2-22.1.i586.rpm /home/abuild/rpmbuild/RPMS/i586/xteddy-debuginfo-2.2-22.2.i586.rpm
[ 120s] skipping -debuginfo package
[ 120s] compare /.build.oldpackages/xteddy-debugsource-2.2-22.1.i586.rpm /home/abuild/rpmbuild/RPMS/i586/xteddy-debugsource-2.2-22.2.i586.rpm
[ 121s] comparing /.build.oldpackages/rpmlint.log and /home/abuild/rpmbuild/OTHER/rpmlint.log
After the "no idea about" is a return 1, so this is considered different without an idea.

Well, the ELF section comparer did not find any difference, but the file is different, probably
due to the .build-id and .gnu_debuglink sections.

if ! diff -u $file1 $file2 > $dfile; then
echo "$file differs in ELF sections"
head -n 200 $dfile
else
echo "WARNING: no idea about $file"
fi
return 1

I think in the else branch it could now return 0 as we did not find a difference.

Ciao, Marcus

--
To unsubscribe, e-mail: opensuse-packaging+***@opensuse.org
To contact the owner, e-mail: opensuse-packaging+***@opensuse.org

Marcus Meissner

2014-07-22 06:54:37 UTC

Permalink

Post by Marcus Meissner

Well, the ELF section comparer did not find any difference, but the file is different, probably
due to the .build-id and .gnu_debuglink sections.
if ! diff -u $file1 $file2 > $dfile; then
echo "$file differs in ELF sections"
head -n 200 $dfile
else
echo "WARNING: no idea about $file"
fi
return 1
I think in the else branch it could now return 0 as we did not find a difference.

SR 241816

Ciao, Marcus

--
To unsubscribe, e-mail: opensuse-packaging+***@opensuse.org
To contact the owner, e-mail: opensuse-packaging+***@opensuse.org